Rewrite Graph component calculations #493
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to make
src/component/graph.rs
easier to understand. To do that, I restructured the functions, which makes the diff very hard to read. Hopefully the new code structure can compensate for that. The functions are mostly executed in the order they're defined in. I didn't make any changes that break the public API, the graph looks almost exactly the same. I tested this with livesplit-one-desktop and the browser LSO version.Some examples of things that are bad about the
master
version of this file:calculate_left_side_coordinates
is never usedWIDTH
andHEIGHT
have arbitrary values (180 and 120) and the graph is later transformed into a0..1
square