Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update image requirement from 0.23.12 to 0.24.0 #514

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 1, 2022

Updates the requirements on image to permit the latest version.

Changelog

Sourced from image's changelog.

Version 0.24.0

Breaking changes

Structural changes:

  • Minimum Rust version is now 1.56 and may change in minor versions until further notice. It is now tracked in the library's Cargo.toml, instead, by the standard [package.rust-version] field. Note: this applies to the library itself. You may need different version resolutions for dependencies when using a non-stable version of Rust.
  • The math::utils::{nq, utils} modules have been removed. These are better served through the color_quant crate and the standard library respectively.
  • All codecs are now available through image::codecs, no longer top-level.
  • ExtendedColorType and DynamicImage have been made #[non_exhaustive], providing more methods instead of exhaustive matching.
  • Reading images through the generic io::Reader, as well as generic convenience interfaces, now requires the underlying reader to be BufRead + Seek. This allows more efficient support more formats. Similarly, writing now requires writers to be Write + Seek.
  • The Bgra* variants of buffers, which were only half-supported, have been removed. The owning buffer types ImageBuffer and DynamicImage fundamentally already make a choice in supported pixel representations. This allows for more consistent internal behavior. Callers are expected to convert formats when using those buffers, which they are required to do in any case already, and which is routinely performed by decoders.

Trait reworks:

  • The Pixel trait is no longer implemented quite as liberally for structs defined in the crate. Instead, it is now restricted to a set of known channel which ensures accuracy in computations involving those channels.
  • The ImageDecoderExt trait has been renamed to ImageDecoderRect, according to its actual functionality.
  • The Pixel trait and its Subpixel field no longer require (or provide) a 'static lifetime bound.
  • The Pixel trait no longer requires specifying an associated, constant ColorType. This was of little relevance to computation but made it much harder to implement and extend correctly. Instead, the private PixelWithColorType extension is added for interfaces that require a properly known variant.
  • Reworked how SubImage interacts with the GenericImage trait. It is now a default implementation. Note that SubImage now has inherent methods that avoid double-indirection, the trait's method will no longer avoid this.
  • The Primitive trait now requires implementations to provide a minimum and maximum logical bound for the purpose of converting to other primitive representations.

Additions

Image formats:

  • Reading lossless WebP is now supported.

... (truncated)

Commits
  • 63489d5 Move planned initialization changes to Unrelease section
  • 899fe92 Bump version number to 0.24
  • dda8c62 Fix unfinished note on AvifEncoder
  • 2c457a5 Fix release note typos caught in review
  • 0da83d6 Draft of Changelog for v0.24
  • 5231652 Merge pull request #1661 from HeroicKatora/upgrade-and-fixes-for-0.24
  • 30e42a1 Comment exception in utils quickcheck
  • dee5590 Succeed early on unusual resize quickcheck case
  • 9a1e601 Update public-private dependency spec
  • 35feee4 Upgrade dependencies
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [image](https://github.com/image-rs/image) to permit the latest version.
- [Release notes](https://github.com/image-rs/image/releases)
- [Changelog](https://github.com/image-rs/image/blob/master/CHANGES.md)
- [Commits](image-rs/image@v0.23.12...v0.24.0)

---
updated-dependencies:
- dependency-name: image
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies A dependency needs to be updated. rust Pull requests that update Rust code labels Feb 1, 2022
@dependabot dependabot bot requested a review from CryZe February 1, 2022 07:10
@kadiwa4
Copy link
Contributor

kadiwa4 commented Feb 5, 2022

Blocked on abonander/img_hash#52.

@CryZe
Copy link
Collaborator

CryZe commented Feb 5, 2022

I wonder if we should just implement the trait in img_hash ourselves, such that it is always compatible with whatever image type / crate we use. The img_hash crate isn't really maintained.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 8, 2022

Looks like image is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this Feb 8, 2022
@dependabot dependabot bot deleted the dependabot/cargo/image-0.24.0 branch February 8, 2022 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies A dependency needs to be updated. rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants