Add timer_current_split_index #747
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexKnauth
force-pushed
the
split-index
branch
from
4fbe4b1 to
a73d1f5
Compare
AlexKnauth
force-pushed
the
split-index
branch
from
a73d1f5 to
05735dc
Compare
AlexKnauth
force-pushed
the
split-index
branch
2 times, most recently
from
e9cfea3 to
9227a1b
Compare
WebEventSink: current_split_index web-sys, js-sys: 0.3.65 0.3.65 is when web_sys starts re-exporting js_sys, which web_event_sink relies on for use web_sys::js_sys
AlexKnauth
force-pushed
the
split-index
branch
from
9227a1b to
2c163a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would be the quickest way to allow auto-splitters to have something similar to settings per split #795: where a List Widget can allow the user to choose list values in the same order as their splits, and the split index allows the auto-splitter to know which index to use from that List.
I have a feeling some version of the first commit of this PR,
Timer trait: add current_split_index, will be necessary even if some better alternative to this, such as a real Settings per Split solution, is implemented instead.See also:
asrcompanion branch: https://github.com/AlexKnauth/asr/tree/split-indexLiveSplit.AutoSplittingRuntimecompanion branch: https://github.com/AlexKnauth/LiveSplit.AutoSplittingRuntime/tree/split-index