Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iss131/disable cosine #135

Merged
merged 5 commits into from
Sep 20, 2022
Merged

Iss131/disable cosine #135

merged 5 commits into from
Sep 20, 2022

Conversation

kasra-hosseini
Copy link
Member

@kasra-hosseini kasra-hosseini commented Sep 15, 2022 •
edited
Loading

TODO:

  • Update/review README
  • Change the version

@mcollardanuy
Copy link
Collaborator

Hi @kasra-hosseini! All looks good, thanks!!

mcollardanuy
mcollardanuy approved these changes Sep 15, 2022
View reviewed changes
Copy link
Collaborator

@mcollardanuy mcollardanuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@kasra-hosseini kasra-hosseini merged commit 5087ce9 into develop Sep 20, 2022
@kallewesterling kallewesterling deleted the iss131/disable_cosine branch October 16, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollardanuy mcollardanuy mcollardanuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kasra-hosseini @mcollardanuy