refactor(main): move globals out of main

cmake/compile_definitions/common.cmake

@@ -49,6 +49,8 @@ set(SUNSHINE_TARGET_FILES
         "${CMAKE_SOURCE_DIR}/src/entry_handler.h"
         "${CMAKE_SOURCE_DIR}/src/file_handler.cpp"
         "${CMAKE_SOURCE_DIR}/src/file_handler.h"
+        "${CMAKE_SOURCE_DIR}/src/globals.cpp"
+        "${CMAKE_SOURCE_DIR}/src/globals.h"
         "${CMAKE_SOURCE_DIR}/src/logging.cpp"
         "${CMAKE_SOURCE_DIR}/src/logging.h"
         "${CMAKE_SOURCE_DIR}/src/main.cpp"

src/entry_handler.h

@@ -12,9 +12,6 @@
 #include "thread_pool.h"
 #include "thread_safe.h"
 
-extern thread_pool_util::ThreadPool task_pool;
-extern bool display_cursor;
-
 // functions
 void
 launch_ui();

src/globals.cpp

@@ -0,0 +1,9 @@
+/**
+ * @file globals.cpp
+ * @brief Implementation for globally accessible variables and functions.
+ */
+#include "globals.h"
+
+safe::mail_t mail::man;
+thread_pool_util::ThreadPool task_pool;
+bool display_cursor = true;

src/globals.h

@@ -0,0 +1,12 @@
+/**
+ * @file globals.h
+ * @brief Header for globally accessible variables and functions.
+ */
+#pragma once
+
+#include "entry_handler.h"
+#include "thread_pool.h"
+
+extern safe::mail_t mail::man;
+extern thread_pool_util::ThreadPool task_pool;
+extern bool display_cursor;

src/input.cpp

@@ -18,6 +18,7 @@ extern "C" {
 
 #include "config.h"
 #include "entry_handler.h"
+#include "globals.h"
 #include "input.h"
 #include "logging.h"
 #include "platform/common.h"

src/main.cpp

@@ -20,6 +20,7 @@
 // local includes
 #include "confighttp.h"
 #include "entry_handler.h"
+#include "globals.h"
 #include "httpcommon.h"
 #include "logging.h"
 #include "main.h"
@@ -38,15 +39,9 @@ extern "C" {
 #include <rs.h>
 }
 
-safe::mail_t mail::man;
-
 using namespace std::literals;
 namespace bl = boost::log;
 
-thread_pool_util::ThreadPool task_pool;
-
-bool display_cursor = true;
-
 struct NoDelete {
   void
   operator()(void *) {}

src/platform/linux/x11grab.cpp

@@ -18,6 +18,7 @@
 
 #include "src/config.h"
 #include "src/entry_handler.h"
+#include "src/globals.h"
 #include "src/logging.h"
 #include "src/task_pool.h"
 #include "src/thread_pool.h"

src/platform/windows/input.cpp

@@ -13,6 +13,7 @@
 #include "misc.h"
 #include "src/config.h"
 #include "src/entry_handler.h"
+#include "src/globals.h"
 #include "src/logging.h"
 #include "src/platform/common.h"
 #include "src/task_pool.h"

src/stream.cpp

@@ -19,6 +19,7 @@ extern "C" {
 
 #include "config.h"
 #include "entry_handler.h"
+#include "globals.h"
 #include "input.h"
 #include "logging.h"
 #include "network.h"

src/video.cpp

@@ -20,6 +20,7 @@ extern "C" {
 #include "cbs.h"
 #include "config.h"
 #include "entry_handler.h"
+#include "globals.h"
 #include "input.h"
 #include "logging.h"
 #include "nvenc/nvenc_base.h"