refactor(main): move map_port to network

[ReenigneArcher]

Description

This PR moves the map_port function out of main, and into network.

Enabler for #1603

Screenshot

Issues Fixed or Closed

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Dependency update (updates to dependencies)
• Documentation update (changes to documentation)
• Repository update (changes to repository files, e.g. .github/...)

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

• I want maintainers to keep my branch updated

[ReenigneArcher]

I'm not really sure why clang format wants network.h first, but whatever.

[cgutman]

Maybe it's treated differently because it's the corresponding .h file for this .cpp file.

[ReenigneArcher]

I was thinking that too but didn't necessarily see the same behavior in other cpp files.

[cgutman]

This looks fine, but would you mind moving map_port into the net namespace too?

[ReenigneArcher]

@cgutman Done! Also found a map_port function in upnp so renamed that to avoid confusion (and a related function for consistency).