Fix wrong path in desktop file

[detiam]

Description

#1817 (comment)

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Dependency update (updates to dependencies)
• Documentation update (changes to documentation)
• Repository update (changes to repository files, e.g. .github/...)

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

• I want maintainers to keep my branch updated

[ReenigneArcher]

Thank you!

[tgurr]

Appears to work fine here with that patch/PR applied to 0.22.0 as well, thanks @detiam.

[ReenigneArcher]

Should this be replaced in other places as well?

[tgurr]

Should this be replaced in other places as well?

https://cmake.org/cmake/help/latest/module/GNUInstallDirs.html#result-variables
Afaik not necessarily, things should work fine for the install() command figuring out the paths as detaild in the CMake documentation. It appears just to be a problem for the configure_file() where this doesn't work as @detiam found out. (I didn't check other projects how and if they generate their desktop files, maybe there's also a saner way in general.)