Populate host latency for kms/x11 grab #2273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am able to test the path through the display_vram_t class but not display_ram_t. I'm not sure how to force it to use display_ram_t |
|
Software encoding should hit display_ram_t |
I had to make a correction but this is also tested and working now. |
|
I was thinking of adding this for X11 as well to compare performance. But then I thought that this would not work if I set the timestamp just after the snapshot because from then on it's just the encoding. Maybe just before the capture operation would make more sense. |
KuleRucket
changed the title
|
Added x11 |
ReenigneArcher
force-pushed
the
kms-host-latency
branch
from
93eceb3 to
5061db2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## nightly #2273 +/- ##
==========================================
- Coverage 6.09% 6.09% -0.01%
==========================================
Files 86 86
Lines 18514 18518 +4
Branches 8404 8404
==========================================
Hits 1129 1129
- Misses 15556 16264 +708
+ Partials 1829 1125 -704
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gschintgen
added a commit
to gschintgen/Sunshine
that referenced
this pull request
May 5, 2024
This commit populates the img->frame_timestamp field, so that Moonlight is now capable of showing the "Host processing latency" in its statistics overlay. It's a complement to PR LizardByte#2273 which did miss the codepath for shm_attr_t::snapshot().
11 tasks
gschintgen
added a commit
to gschintgen/Sunshine
that referenced
this pull request
May 11, 2024
This commit populates the img->frame_timestamp field, so that Moonlight is now capable of showing the "Host processing latency" in its statistics overlay. It's a complement to PR LizardByte#2273 which did miss the codepath for shm_attr_t::snapshot().
ReenigneArcher
pushed a commit
to gschintgen/Sunshine
that referenced
this pull request
May 12, 2024
This commit populates the img->frame_timestamp field, so that Moonlight is now capable of showing the "Host processing latency" in its statistics overlay. It's a complement to PR LizardByte#2273 which did miss the codepath for shm_attr_t::snapshot().
KuleRucket
added a commit
to KuleRucket/Sunshine
that referenced
this pull request
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR populates the frame_timestamp at the point that the KMS and X11 capture is done. This allows Moonlight to show the host latency in the statistics like it does for Windows.
Screenshot
Issues Fixed or Closed
n/a
Type of Change
.github/...)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.