Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(linux)!: drop ubuntu 20.04 #2327

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

ReenigneArcher
Copy link
Member

Description

Drop support for Ubuntu 20.04.

While, I understand Ubuntu will support this release for another year with security updates I think it time we drop support for providing new package for it on our side.

There are a few reasons to consider dropping support.

  • Boost version is too old, which has hindered many PRs in the past and will likely hinder many more going forward. One current example is Use C++20. #2322. Previous PRs that I can remember wanted to use Boost JSON, but couldn't because it wasn't added until Boost 1.75.0.
  • Ubuntu 24.04 will be shipping soon, supporting 3 Ubuntu distros will strain the CI. I believe support 2 of each Ubuntu/Debian/Fedora is sufficient.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher ReenigneArcher requested a review from cgutman March 30, 2024 00:29
Copy link

codecov bot commented Mar 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.82%. Comparing base (e158878) to head (e40a266).

Additional details and impacted files
@@            Coverage Diff             @@
##           nightly   #2327      +/-   ##
==========================================
- Coverage     7.83%   6.82%   -1.02%     
==========================================
  Files           65      68       +3     
  Lines        13680   14424     +744     
  Branches      6197    6353     +156     
==========================================
- Hits          1072     984      -88     
- Misses       11681   12668     +987     
+ Partials       927     772     -155     
Flag Coverage Δ
Linux ?
Windows 2.00% <ø> (?)
macOS-12 8.73% <ø> (-0.14%) ⬇️
macOS-13 8.07% <ø> (?)
macOS-14 8.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 69 files with indirect coverage changes

@tez011 tez011 mentioned this pull request Mar 31, 2024
11 tasks
@ReenigneArcher ReenigneArcher force-pushed the build(linux)!-drop-ubuntu-20.04 branch from c531a07 to 7225180 Compare April 2, 2024 01:01
@ReenigneArcher ReenigneArcher force-pushed the build(linux)!-drop-ubuntu-20.04 branch from 7225180 to 80aadfc Compare April 3, 2024 02:34
@ReenigneArcher ReenigneArcher force-pushed the build(linux)!-drop-ubuntu-20.04 branch from 80aadfc to e40a266 Compare April 4, 2024 01:51
@ReenigneArcher ReenigneArcher merged commit 699b2c1 into nightly Apr 4, 2024
51 checks passed
@ReenigneArcher ReenigneArcher deleted the build(linux)!-drop-ubuntu-20.04 branch April 4, 2024 02:52
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant