-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(logging): add logging namespace and create logging::init method #2336
fix(logging): add logging namespace and create logging::init method #2336
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## nightly #2336 +/- ##
==========================================
+ Coverage 6.10% 6.50% +0.39%
==========================================
Files 85 85
Lines 18303 18382 +79
Branches 8319 8348 +29
==========================================
+ Hits 1118 1196 +78
+ Misses 16151 15360 -791
- Partials 1034 1826 +792
Flags with carried forward coverage won't be shown. Click here to find out more.
|
7b2b47b
to
1e2d83d
Compare
This comment was marked as resolved.
This comment was marked as resolved.
57847c6
to
0e7bd21
Compare
|
||
// Flush after each log record to ensure log file contents on disk isn't stale. | ||
// This is particularly important when running from a Windows service. | ||
sink->locked_backend()->auto_flush(true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is enabled, why are we even flushing manually?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure, perhaps the manual flush was just left over from before auto_flush was added? Maybe @cgutman has some idea?
0e083ed
to
d9794e2
Compare
d9794e2
to
6e09df4
Compare
77e7eb0
to
e88ee8b
Compare
d71a354
to
cfdef36
Compare
cfdef36
to
cfbf529
Compare
a31cf23
to
ac751ad
Compare
ac751ad
to
51b6b20
Compare
51b6b20
to
b19a026
Compare
Description
Boost logs are captured in unit tests, and it was discovered that some encoder logging messages were not captured. This PR moves more (and hopefully all) logging setup to a
logging::init
method.Example test output prior to this PR:
Todo:
Screenshot
Issues Fixed or Closed
Type of Change
.github/...
)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.