Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(cmake): build web-ui target with cmd instead of bash on windows #2340

Conversation

ReenigneArcher
Copy link
Member

Description

In some cases, the command using bash to build the web-ui would fail, such as:

  • Using the web-ui configuration in CLion
  • User doesn't have bash installed, for whatever reason

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher
Copy link
Member Author

@FrogTheFrog FYI

Copy link

codecov bot commented Mar 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.10%. Comparing base (b4739b0) to head (bff3992).

Additional details and impacted files
@@           Coverage Diff           @@
##           nightly   #2340   +/-   ##
=======================================
  Coverage     6.10%   6.10%           
=======================================
  Files           85      85           
  Lines        18303   18303           
  Branches      8319    8319           
=======================================
  Hits          1118    1118           
- Misses       15374   15376    +2     
+ Partials      1811    1809    -2     
Flag Coverage Δ
Linux 4.11% <ø> (ø)
Windows 1.51% <ø> (ø)
macOS-12 8.11% <ø> (-0.02%) ⬇️
macOS-13 7.46% <ø> (ø)
macOS-14 7.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@ReenigneArcher ReenigneArcher changed the title build(cmake): build web-ui target with cmd instead of bash build(cmake): build web-ui target with cmd instead of bash on windows Mar 31, 2024
@ReenigneArcher ReenigneArcher merged commit 9020c2c into nightly Mar 31, 2024
51 checks passed
@ReenigneArcher ReenigneArcher deleted the build(cmake)-build-web-ui-target-with-cmd-instead-of-bash branch March 31, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant