Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(macos): do not always run tests for macports build #2360

Merged

Conversation

ReenigneArcher
Copy link
Member

Description

Tests should not run if build fails.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.50%. Comparing base (699b2c1) to head (b508733).

Additional details and impacted files
@@           Coverage Diff            @@
##           nightly   #2360    +/-   ##
========================================
  Coverage     6.50%   6.50%            
========================================
  Files           85      85            
  Lines        18382   18382            
  Branches      8348    8348            
========================================
  Hits          1196    1196            
+ Misses       16062   15360   -702     
- Partials      1124    1826   +702     
Flag Coverage Δ
Linux 4.42% <ø> (ø)
Windows 2.00% <ø> (ø)
macOS-12 8.74% <ø> (+0.01%) ⬆️
macOS-13 8.07% <ø> (ø)
macOS-14 8.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 25 files with indirect coverage changes

@ReenigneArcher ReenigneArcher force-pushed the ci(macos)-do-not-always-run-tests-for-macports-build branch from 6c02b3c to b508733 Compare April 4, 2024 12:40
@ReenigneArcher ReenigneArcher merged commit cd46565 into nightly Apr 4, 2024
51 checks passed
@ReenigneArcher ReenigneArcher deleted the ci(macos)-do-not-always-run-tests-for-macports-build branch April 4, 2024 13:36
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant