Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(linux): Set default SUNSHINE_EXECUTABLE_PATH earlier so it works #2373

Closed
wants to merge 1 commit into from

Conversation

chewi
Copy link
Contributor

@chewi chewi commented Apr 5, 2024

Description

If you don't give -DSUNSHINE_EXECUTABLE_PATH, then the systemd unit ends up with a blank ExecStart= because the default value is set too late. This sets it earlier.

Issues Fixed or Closed

Bug: gentoo/gentoo#36078

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher
Copy link
Member

Thanks for the PR. I put your changes into #2375 (trying to get a release out sooner rather than later).

@chewi chewi deleted the default-executable-path branch April 6, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants