Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): fix quicksync locale strings #2418

Merged
merged 1 commit into from
Apr 14, 2024

Conversation

ReenigneArcher
Copy link
Member

Description

Fixes some typos in the the quicksync locale strings.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher ReenigneArcher added this to the v0.23.1 milestone Apr 14, 2024
Copy link

codecov bot commented Apr 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 7.38%. Comparing base (358bb30) to head (ffa116a).

Additional details and impacted files
@@           Coverage Diff            @@
##           nightly   #2418    +/-   ##
========================================
  Coverage     7.38%   7.38%            
========================================
  Files           96      96            
  Lines        18978   18978            
  Branches      8089    8197   +108     
========================================
  Hits          1402    1402            
+ Misses       16530   15874   -656     
- Partials      1046    1702   +656     
Flag Coverage Δ
Linux 6.91% <ø> (ø)
Windows 2.04% <ø> (ø)
macOS-12 8.58% <ø> (+0.01%) ⬆️
macOS-13 7.77% <ø> (ø)
macOS-14 8.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 28 files with indirect coverage changes

@ReenigneArcher ReenigneArcher merged commit fb4d4f5 into nightly Apr 14, 2024
51 checks passed
@ReenigneArcher ReenigneArcher deleted the fix(ui)-fix-quicksync-locale-strings branch April 14, 2024 13:34
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate "fastest" option in QuickSync Preset dropdown
1 participant