Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(linux): add guide for discord audio #2447

Merged
merged 16 commits into from
Apr 19, 2024

Conversation

RickAndTired
Copy link
Contributor

Description

Linux Guide - How to not stream Discord call audio

Notes

I wasn't sure how to handle the images, so I placed them here:
docs/source/about/guides/linux/discord_calls/

The images are linked to my fork and should be updated to the official LizardByte repo if this PR is merged

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@CLAassistant
Copy link

CLAassistant commented Apr 18, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@ReenigneArcher ReenigneArcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you place the images in ./docs/source/images?

I've also made some suggestions for having the steps in a numbered list.

docs/source/about/guides/linux/discord_calls.rst Outdated Show resolved Hide resolved
docs/source/about/guides/linux/discord_calls.rst Outdated Show resolved Hide resolved
docs/source/about/guides/linux/discord_calls.rst Outdated Show resolved Hide resolved
docs/source/about/guides/linux/discord_calls.rst Outdated Show resolved Hide resolved
docs/source/about/guides/linux/discord_calls.rst Outdated Show resolved Hide resolved
docs/source/about/guides/linux/discord_calls.rst Outdated Show resolved Hide resolved
docs/source/about/guides/linux/discord_calls.rst Outdated Show resolved Hide resolved
docs/source/about/guides/linux/discord_calls.rst Outdated Show resolved Hide resolved
docs/source/about/guides/linux/discord_calls.rst Outdated Show resolved Hide resolved
docs/source/about/guides/linux/discord_calls.rst Outdated Show resolved Hide resolved
@RickAndTired
Copy link
Contributor Author

Can you place the images in ./docs/source/images?

I've also made some suggestions for having the steps in a numbered list.

I moved the images to the requested directory
I included the numbered list
(I had tried bullet points because the numbers were being reset by the images, I didn't notice the indented images fixed that)

Copy link
Member

@ReenigneArcher ReenigneArcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A few more small adjustments needed.

You can see the preview here: https://lizardbyte--2447.org.readthedocs.build/projects/sunshine/en/2447/about/guides/linux/discord_calls.html

docs/source/about/guides/linux/discord_calls.rst Outdated Show resolved Hide resolved
docs/source/about/guides/linux/discord_calls.rst Outdated Show resolved Hide resolved
@ReenigneArcher ReenigneArcher changed the title Linux Guide - How to not stream Discord call audio docs(linux): add guide for discord audio Apr 19, 2024
RickAndTired and others added 2 commits April 18, 2024 19:09
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.77%. Comparing base (50a02db) to head (4a608f2).

Additional details and impacted files
@@           Coverage Diff            @@
##           nightly   #2447    +/-   ##
========================================
  Coverage     6.77%   6.77%            
========================================
  Files           86      86            
  Lines        17523   17523            
  Branches      8134    8015   -119     
========================================
  Hits          1187    1187            
+ Misses       15444   15396    -48     
- Partials       892     940    +48     
Flag Coverage Δ
Linux 5.75% <ø> (ø)
Windows 2.04% <ø> (ø)
macOS-12 8.44% <ø> (-0.13%) ⬇️
macOS-13 7.78% <ø> (ø)
macOS-14 8.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 16 files with indirect coverage changes

@ReenigneArcher ReenigneArcher merged commit 9e0182b into LizardByte:nightly Apr 19, 2024
53 checks passed
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Jun 6, 2024
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants