-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(linux): add guide for discord audio #2447
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you place the images in ./docs/source/images
?
I've also made some suggestions for having the steps in a numbered list.
I moved the images to the requested directory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! A few more small adjustments needed.
You can see the preview here: https://lizardbyte--2447.org.readthedocs.build/projects/sunshine/en/2447/about/guides/linux/discord_calls.html
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## nightly #2447 +/- ##
========================================
Coverage 6.77% 6.77%
========================================
Files 86 86
Lines 17523 17523
Branches 8134 8015 -119
========================================
Hits 1187 1187
+ Misses 15444 15396 -48
- Partials 892 940 +48
Flags with carried forward coverage won't be shown. Click here to find out more. |
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
Description
Linux Guide - How to not stream Discord call audio
Notes
I wasn't sure how to handle the images, so I placed them here:
docs/source/about/guides/linux/discord_calls/
The images are linked to my fork and should be updated to the official LizardByte repo if this PR is merged
Type of Change
.github/...
)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.