-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(codeql): fix codeql builds #2475
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## nightly #2475 +/- ##
========================================
Coverage 7.04% 7.04%
========================================
Files 87 87
Lines 17697 17697
Branches 8405 8405
========================================
Hits 1246 1246
+ Misses 13874 13712 -162
- Partials 2577 2739 +162
Flags with carried forward coverage won't be shown. Click here to find out more. |
383ca08
to
90175fe
Compare
macOS issue: github/codeql-action#2266 Not sure about Ubuntu issue for now. |
ad41292
to
a57de90
Compare
.codeql-prebuild-cpp-macOS.sh
Outdated
#echo "arch: $(arch)" | ||
#echo "uname -p: $(uname -p)" | ||
#echo "uname -a: $(uname -a)" | ||
#if [[ "$(uname -m)" == "arm64" ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uname can fail, the best way currently is to do:
#if [[ "$(uname -m)" == "arm64" ]]; then | |
#if [[ $(sysctl -n machdep.cpu.brand_string) =~ "Apple" ]]; then |
This may solve it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll keep that in mind, if I could even get arch -arm64
to work. Currently it doesn't even if I hard code it. https://github.com/LizardByte/Sunshine/actions/runs/9055643443/job/24877061140?pr=2475#step:6:48
Which is odd, because that's the suggestion that the original error gives. https://github.com/LizardByte/Sunshine/actions/runs/9054788502/job/24875053065#step:6:56
I also don't understand how the brew install only fails if it's after the code ql init step: github/codeql-action#2266
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, thats odd.
arm64e... I guess, ARMv8.3+, maybe they are using an old version of Clang, or LLVM that don't support ARMv8.3+ and they are replacing the version available to the environment?
Interesting links:
https://developer.apple.com/documentation/security/preparing_your_app_to_work_with_pointer_authentication
https://lists.llvm.org/pipermail/llvm-dev/2019-October/136091.html
https://github.com/lelegard/arm-cpusysregs/blob/main/docs/arm64e-on-macos.md
c3d9ea5
to
8d940d8
Compare
8d940d8
to
f981b85
Compare
Description
This change requires an update to our .github repo, per LizardByte/.github#330
Screenshot
Issues Fixed or Closed
Type of Change
.github/...
)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.