Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(codeql): fix codeql builds #2475

Merged
merged 1 commit into from
May 14, 2024
Merged

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Apr 27, 2024

Description

This change requires an update to our .github repo, per LizardByte/.github#330

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

Copy link

codecov bot commented Apr 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 7.04%. Comparing base (ff54ab2) to head (f981b85).

Additional details and impacted files
@@           Coverage Diff            @@
##           nightly   #2475    +/-   ##
========================================
  Coverage     7.04%   7.04%            
========================================
  Files           87      87            
  Lines        17697   17697            
  Branches      8405    8405            
========================================
  Hits          1246    1246            
+ Misses       13874   13712   -162     
- Partials      2577    2739   +162     
Flag Coverage Δ
Linux 5.35% <ø> (ø)
Windows 2.56% <ø> (ø)
macOS-12 8.07% <ø> (-0.02%) ⬇️
macOS-13 7.98% <ø> (ø)
macOS-14 8.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 24 files with indirect coverage changes

@ReenigneArcher ReenigneArcher force-pushed the ci(codeql)-fix-codeql-builds branch 3 times, most recently from 383ca08 to 90175fe Compare April 27, 2024 16:32
@ReenigneArcher
Copy link
Member Author

macOS issue: github/codeql-action#2266

Not sure about Ubuntu issue for now.

@ReenigneArcher ReenigneArcher deleted the ci(codeql)-fix-codeql-builds branch April 29, 2024 14:12
@ReenigneArcher ReenigneArcher restored the ci(codeql)-fix-codeql-builds branch May 12, 2024 19:05
@ReenigneArcher ReenigneArcher marked this pull request as draft May 12, 2024 19:05
@ReenigneArcher ReenigneArcher force-pushed the ci(codeql)-fix-codeql-builds branch 6 times, most recently from ad41292 to a57de90 Compare May 13, 2024 01:04
#echo "arch: $(arch)"
#echo "uname -p: $(uname -p)"
#echo "uname -a: $(uname -a)"
#if [[ "$(uname -m)" == "arm64" ]]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uname can fail, the best way currently is to do:

Suggested change
#if [[ "$(uname -m)" == "arm64" ]]; then
#if [[ $(sysctl -n machdep.cpu.brand_string) =~ "Apple" ]]; then

This may solve it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll keep that in mind, if I could even get arch -arm64 to work. Currently it doesn't even if I hard code it. https://github.com/LizardByte/Sunshine/actions/runs/9055643443/job/24877061140?pr=2475#step:6:48

Which is odd, because that's the suggestion that the original error gives. https://github.com/LizardByte/Sunshine/actions/runs/9054788502/job/24875053065#step:6:56

I also don't understand how the brew install only fails if it's after the code ql init step: github/codeql-action#2266

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, thats odd.

arm64e... I guess, ARMv8.3+, maybe they are using an old version of Clang, or LLVM that don't support ARMv8.3+ and they are replacing the version available to the environment?

Interesting links:
https://developer.apple.com/documentation/security/preparing_your_app_to_work_with_pointer_authentication

https://lists.llvm.org/pipermail/llvm-dev/2019-October/136091.html

https://github.com/lelegard/arm-cpusysregs/blob/main/docs/arm64e-on-macos.md

@ReenigneArcher ReenigneArcher force-pushed the ci(codeql)-fix-codeql-builds branch 5 times, most recently from c3d9ea5 to 8d940d8 Compare May 14, 2024 22:37
@ReenigneArcher ReenigneArcher marked this pull request as ready for review May 14, 2024 22:43
@ReenigneArcher ReenigneArcher merged commit d70a17a into nightly May 14, 2024
53 checks passed
@ReenigneArcher ReenigneArcher deleted the ci(codeql)-fix-codeql-builds branch May 14, 2024 23:20
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants