ci(flatpak): add flatpak builder lint

[ReenigneArcher]

Description

Add flatpak manifest linting, per discussion from flathub/dev.lizardbyte.app.Sunshine#36 (comment)

Screenshot

Issues Fixed or Closed

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Dependency update (updates to dependencies)
• Documentation update (changes to documentation)
• Repository update (changes to repository files, e.g. .github/...)

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

• I want maintainers to keep my branch updated

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 8.95%. Comparing base (acccacf) to head (9b4d191).
Report is 136 commits behind head on master.

Additional details and impacted files

@@          Coverage Diff           @@
##           master   #2799   +/-   ##
======================================
  Coverage    8.95%   8.95%           
======================================
  Files          95      95           
  Lines       17386   17386           
  Branches     8268    8268           
======================================
  Hits         1557    1557           
  Misses      12964   12964           
  Partials     2865    2865           

Flag	Coverage Δ
Linux	6.78% <ø> (ø)
Windows	4.16% <ø> (ø)
macOS-12	10.01% <ø> (ø)
macOS-13	9.92% <ø> (-0.02%)	⬇️
macOS-14	10.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[barthalion]

should be just https://dl.flathub.org/media. We're discussing how to disable this check for builds not targetting Flathub.

[ReenigneArcher]

Thank you!

I have one question. Is the "--exceptions" arg only going to allow exceptions that are for this flatpak id? Or it will pass any if the rule says exceptions allowed?

[ReenigneArcher]

I must have missed something.

usage: flatpak-builder-lint [-h] [--version] [--exceptions] [--appid APPID]
                            [--cwd] [--ref REF]
                            {builddir,repo,manifest,appstream} path
flatpak-builder-lint: error: unrecognized arguments: --mirror-screenshots-url=https://dl.flathub.org/media

[ReenigneArcher]

@gschintgen would you be able to test this PR? Mostly I'd like to ensure that deb or rpm packages didn't break due to any of the CMake changes.

[gschintgen]

Ok, sure, I'll install the .deb later (next 24h) and let you know.

…

On July 7, 2024 12:36:43 AM GMT+02:00, ReenigneArcher ***@***.***> wrote: @gschintgen would you be able to test this PR? Mostly I'd like to ensure that deb or rpm packages didn't break due to any of the CMake changes. -- Reply to this email directly or view it on GitHub: #2799 (comment) You are receiving this because you were mentioned. Message ID: ***@***.***>

[gschintgen]

I downloaded the last available deb from the CI here, that is the one before your (minor) last force push. It seems to work fine. I also checked out the PR locally and built it. I can't say there's anything out of the ordinary. But I only did very cursory testing (a few seconds of remote desktop.)

I had a quick look at sunshine.desktop and sunshine.service (since the respective .in files were modified) and they seem fine.