Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(curl): use stronger SSL and TLS versions #3241

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

ReenigneArcher
Copy link
Member

Description

Use stronger SSL and TLS version in curl, for download_file function. This function is used to download cover images from our games database.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@ReenigneArcher ReenigneArcher force-pushed the fix/curl/use-stronger-SSL-and-TLS-versions branch from 06c48e4 to e74a756 Compare September 29, 2024 22:26
@ReenigneArcher ReenigneArcher added this to the stable release milestone Sep 29, 2024
Copy link

Copy link

codecov bot commented Sep 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.82%. Comparing base (1839d59) to head (e74a756).
Report is 92 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #3241   +/-   ##
======================================
  Coverage    9.82%   9.82%           
======================================
  Files         101     101           
  Lines       17980   17981    +1     
  Branches     8418    8419    +1     
======================================
+ Hits         1766    1767    +1     
+ Misses      13329   13323    -6     
- Partials     2885    2891    +6     
Flag Coverage Δ
Linux 7.27% <100.00%> (+<0.01%) ⬆️
Windows 5.10% <100.00%> (+<0.01%) ⬆️
macOS-13 10.70% <0.00%> (-0.02%) ⬇️
macOS-14 10.01% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/httpcommon.cpp 26.08% <100.00%> (+0.53%) ⬆️

... and 23 files with indirect coverage changes

@ReenigneArcher ReenigneArcher enabled auto-merge (squash) September 29, 2024 23:27
@ReenigneArcher ReenigneArcher merged commit fb712e3 into master Sep 29, 2024
36 checks passed
@ReenigneArcher ReenigneArcher deleted the fix/curl/use-stronger-SSL-and-TLS-versions branch September 29, 2024 23:48
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Oct 9, 2024
qiin2333 pushed a commit to qiin2333/Sunshine-Foundation that referenced this pull request Oct 15, 2024
qiin2333 pushed a commit to qiin2333/Sunshine-Foundation that referenced this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant