Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(linux): fail build if capture dependencies not found #3305

Conversation

ReenigneArcher
Copy link
Member

Description

Builds can currently silently fail or skip important features. This PR will fail builds if required dependencies are missing, forcing packagers to explicitly disable whatever they don't want. CUDA can be enabled, with an extra option to not fail due to it being an optional dependencies with some packages although the default behavior is to fail.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.13%. Comparing base (67ab6e3) to head (10a9067).
Report is 80 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3305   +/-   ##
=======================================
  Coverage   11.12%   11.13%           
=======================================
  Files          99       99           
  Lines       17211    17211           
  Branches     8023     8023           
=======================================
+ Hits         1915     1916    +1     
  Misses      12594    12594           
+ Partials     2702     2701    -1     
Flag Coverage Δ
Linux 8.42% <ø> (ø)
Windows 5.19% <ø> (ø)
macOS-13 13.60% <ø> (+0.01%) ⬆️
macOS-14 12.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@ReenigneArcher ReenigneArcher force-pushed the build/linux/fail-build-if-capture-dependencies-not-found branch from bcacbc4 to 10a9067 Compare October 14, 2024 21:59
Copy link

@ReenigneArcher ReenigneArcher enabled auto-merge (squash) October 14, 2024 22:08
@ReenigneArcher ReenigneArcher merged commit 7352e72 into master Oct 14, 2024
36 checks passed
@ReenigneArcher ReenigneArcher deleted the build/linux/fail-build-if-capture-dependencies-not-found branch October 14, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant