Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(various): tedious updates #3316

Merged
merged 3 commits into from
Oct 20, 2024
Merged

Conversation

ReenigneArcher
Copy link
Member

Description

  • Bump googletest to v1.15.2 and change tracking branch to main as googeltest doesn't seem to update release branches
  • Fixes for .gitmodules file
  • Remove an extra line break in cmake
  • Improve error message for cuda not found.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@ReenigneArcher
Copy link
Member Author

@cgutman this addresses your comment 7352e72#commitcomment-148119479 and a few other tedious updates. We can probably add other tedious updates here if you find any.

Copy link

Copy link

codecov bot commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.12%. Comparing base (a3ba700) to head (0d2ddec).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3316   +/-   ##
=======================================
  Coverage   11.12%   11.12%           
=======================================
  Files          99       99           
  Lines       17211    17211           
  Branches     8023     8023           
=======================================
  Hits         1915     1915           
  Misses      12594    12594           
  Partials     2702     2702           
Flag Coverage Δ
Linux 8.42% <ø> (ø)
Windows 5.19% <ø> (ø)
macOS-13 13.60% <ø> (ø)
macOS-14 12.59% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ReenigneArcher ReenigneArcher added this to the stable release milestone Oct 19, 2024
@ReenigneArcher ReenigneArcher merged commit 60cf242 into master Oct 20, 2024
36 checks passed
@ReenigneArcher ReenigneArcher deleted the chore/various/tedious-updates branch October 20, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant