-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(process): proc status lost when streaming #3417
Open
MiroKaku
wants to merge
10
commits into
LizardByte:master
Choose a base branch
from
MiroKaku:fix/process/proc_status_lost
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
327ce77
fix(process): proc status lost when streaming
MiroKaku dae0997
Merge branch 'master' into fix/process/proc_status_lost
MiroKaku c70404a
Merge branch 'master' into fix/process/proc_status_lost
MiroKaku fb78d68
merge master
MiroKaku c53681a
docs(process): add comments
MiroKaku 1352925
merge master: rollback
MiroKaku 04947f3
Merge branch 'master' into fix/process/proc_status_lost
MiroKaku 06ad747
style: process.cpp
MiroKaku 6a1465b
fix(process): typo
MiroKaku 56d0699
Merge branch 'master' into fix/process/proc_status_lost
MiroKaku File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After looking into this I have found another bug related to
_env
. It is used interminate
function, this means we have to preserve the_env
until process terminates :/The moment we call
execute
we should copy the_env
to a member variable_app_env
(name is debatable) and replace every usage of_env
withinexecute
andterminate
with_app_env
(except the first one where we copy it of course). Or we could store the new ENV to_current_env
and the in execute copy it (_env = _current_env
). I prefer the first renaming option, but whatever is easier is ok.