Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): fix boost 1.87 compatibility #3457

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Dec 16, 2024

Description

Boost 1.87 removes asio::io_service. See: boostorg/asio#110

These changes seem compatible with 1.86 and 1.87 so technically we don't need to update to 1.87.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@ReenigneArcher ReenigneArcher force-pushed the build/deps/fix-boost-1.87-compatibility branch from 9d62829 to 9152cdc Compare December 16, 2024 23:41
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 11.17%. Comparing base (e062484) to head (9152cdc).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/rtsp.cpp 0.00% 4 Missing and 2 partials ⚠️
src/stream.cpp 0.00% 3 Missing and 1 partial ⚠️
src/nvhttp.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #3457    +/-   ##
========================================
  Coverage   11.17%   11.17%            
========================================
  Files         100      100            
  Lines       17310    17310            
  Branches     8069     8069            
========================================
  Hits         1934     1934            
- Misses      12671    12812   +141     
+ Partials     2705     2564   -141     
Flag Coverage Δ
Linux 8.43% <0.00%> (ø)
Windows 5.38% <0.00%> (ø)
macOS-13 13.73% <0.00%> (+0.01%) ⬆️
macOS-14 12.72% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/nvhttp.cpp 1.39% <0.00%> (ø)
src/stream.cpp 3.79% <0.00%> (ø)
src/rtsp.cpp 2.77% <0.00%> (ø)

... and 20 files with indirect coverage changes

@ReenigneArcher ReenigneArcher marked this pull request as ready for review December 17, 2024 00:15
Copy link
Collaborator

@FrogTheFrog FrogTheFrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ReenigneArcher ReenigneArcher merged commit 1e2fc2e into master Dec 17, 2024
35 of 37 checks passed
@ReenigneArcher ReenigneArcher deleted the build/deps/fix-boost-1.87-compatibility branch December 17, 2024 13:53
TheElixZammuto pushed a commit to TheElixZammuto/Sunshine-1 that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants