Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(docker): fix docker artifacts #3472

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Dec 21, 2024

Description

Something changed with how artifacts are extracted from the docker builds. This fixes that.

These changes need to also be added to the .github repo.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Copy link

codecov bot commented Dec 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.16%. Comparing base (364ef93) to head (01c1de3).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3472      +/-   ##
==========================================
- Coverage   11.17%   11.16%   -0.01%     
==========================================
  Files         100      100              
  Lines       17310    17310              
  Branches     8069     8069              
==========================================
- Hits         1934     1933       -1     
+ Misses      12812    12668     -144     
- Partials     2564     2709     +145     
Flag Coverage Δ
Linux 8.43% <ø> (ø)
Windows 5.38% <ø> (ø)
macOS-13 13.70% <ø> (-0.02%) ⬇️
macOS-14 12.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 25 files with indirect coverage changes

@ReenigneArcher ReenigneArcher force-pushed the build/docker/fix-docker-artifacts branch 2 times, most recently from 3fc8d29 to 09eaffb Compare December 21, 2024 16:27
@ReenigneArcher ReenigneArcher force-pushed the build/docker/fix-docker-artifacts branch from 09eaffb to b7cc82e Compare December 21, 2024 17:02
@ReenigneArcher ReenigneArcher force-pushed the build/docker/fix-docker-artifacts branch from b7cc82e to 01c1de3 Compare December 21, 2024 17:18
@ReenigneArcher ReenigneArcher marked this pull request as ready for review December 21, 2024 17:39

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@ReenigneArcher ReenigneArcher merged commit e47aa9f into master Dec 21, 2024
36 of 37 checks passed
@ReenigneArcher ReenigneArcher deleted the build/docker/fix-docker-artifacts branch December 21, 2024 17:53
TheElixZammuto pushed a commit to TheElixZammuto/Sunshine-1 that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant