Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linux/inputtino): DualSense native support without Steam Input #3600

Merged
merged 3 commits into from
Feb 9, 2025

Conversation

ABeltramo
Copy link
Collaborator

@ABeltramo ABeltramo commented Jan 27, 2025

Description

This PR just updates inputtino to the latest in games-on-whales/inputtino#19
Games tested:

  • Helldivers 2
  • Horizon Forbidden West

Still a draft until users can confirm this actually fixes it.
I'm writing down a high level rationale behind all this for the more curious, stay tuned 😉

[EDIT]
blog posts are up:

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.61%. Comparing base (ac2fc48) to head (d5c58aa).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3600   +/-   ##
=======================================
  Coverage   11.61%   11.61%           
=======================================
  Files          92       92           
  Lines       17333    17333           
  Branches     8096     8096           
=======================================
  Hits         2014     2014           
  Misses      12832    12832           
  Partials     2487     2487           
Flag Coverage Δ
Linux 11.29% <ø> (ø)
Windows 13.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ReenigneArcher ReenigneArcher self-assigned this Jan 30, 2025
@ReenigneArcher
Copy link
Member

I noticed the commit of the submodule doesn't match the latest in inputtino. games-on-whales/inputtino@8065aeb...921f55e

It should be 311fd2deea8743c2d87aec5274978d1523de90fa

Also, seems like this is an overall improvement over the current state (according to a comment in the linked issue) so can probably merge this even if everything isn't perfect yet.

@ABeltramo
Copy link
Collaborator Author

I noticed the commit of the submodule doesn't match the latest in inputtino.

Yeah, I've most likely initally pushed the commit when the PR was still opened in inputtino and it's now not the latest since I've merged over there.

Also, seems like this is an overall improvement over the current state (according to a comment in the linked issue) so can probably merge this even if everything isn't perfect yet.

Agreed, it shouldn't cause any more issues; worst case it doesn't fix the issue that is already present.
Do you want me to rebase and point to the latest commit?

@ReenigneArcher
Copy link
Member

Do you want me to rebase and point to the latest commit?

If you could that would be great, otherwise dependabot will just open another PR immediately

@ABeltramo ABeltramo marked this pull request as ready for review February 9, 2025 17:46
Copy link

sonarqubecloud bot commented Feb 9, 2025

@ReenigneArcher ReenigneArcher changed the title fix: linux/inputtino - DualSense native support without Steam Input fix(linux/inputtino): DualSense native support without Steam Input Feb 9, 2025
@ReenigneArcher ReenigneArcher enabled auto-merge (squash) February 9, 2025 18:12
@ReenigneArcher ReenigneArcher merged commit ff0ed25 into LizardByte:master Feb 9, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dualsense 5 only partially working (pre-release v2024.1218.135629)
2 participants