Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Max Bitrate option #3628

Open
wants to merge 43 commits into
base: master
Choose a base branch
from
Open

feat: Add Max Bitrate option #3628

wants to merge 43 commits into from
+60 −25

Conversation

utkarshdalal
Copy link

Description

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

ReenigneArcher and others added 30 commits October 30, 2022 15:05
@ReenigneArcher
Merge pull request LizardByte#332 from LizardByte/nightly
660d8e1 
v0.15.0
@ReenigneArcher
Merge pull request LizardByte#456 from LizardByte/nightly
1e6d9da 
v0.15.0 resubmit
@ReenigneArcher
Merge pull request LizardByte#458 from LizardByte/nightly
8509ee7 
v0.15.0 resubmit
@ReenigneArcher
Merge pull request LizardByte#460 from LizardByte/nightly
e1b112c 
v0.15.0 resubmit
@ReenigneArcher
Merge pull request LizardByte#467 from LizardByte/nightly
08d623c 
v0.16.0
@ReenigneArcher
Merge pull request LizardByte#567 from LizardByte/nightly
b2fe042 
v0.17.0
@ReenigneArcher
Merge pull request LizardByte#738 from LizardByte/nightly
b2c5da2 
v0.18.0
@ReenigneArcher
Merge pull request LizardByte#866 from LizardByte/nightly
09dff34 
v0.18.1
@ReenigneArcher
Merge pull request LizardByte#877 from LizardByte/nightly
446825b 
v0.18.2
@ReenigneArcher
Merge pull request LizardByte#929 from LizardByte/nightly
9563419 
v0.18.3
@ReenigneArcher
Merge pull request LizardByte#954 from LizardByte/nightly
0dfbcfd 
v0.18.4
@ReenigneArcher
Merge pull request LizardByte#969 from LizardByte/nightly
483e225 
v0.19.0
@ReenigneArcher
Merge pull request LizardByte#1105 from LizardByte/nightly
d70d084 
v0.19.1
@ReenigneArcher
Merge pull request LizardByte#1115 from LizardByte/nightly
31e8b79 
v0.20.0
@utkarshdalal
added max bitrate variable that overrides bitrate set by moonlight cl…
9cfa228 
…ient.
@utkarshdalal
corrected syntax errors
6d39591
@utkarshdalal
updated variable in publish.cpp for windows to build in github action
23fbeae
@utkarshdalal
added empty line to force release
d8b62ff
@utkarshdalal
Updated description for max_bitrate param
72551fe
@utkarshdalal
Addressed code review comments
3fb13de
@utkarshdalal
Merge branch 'nightly' into add_max_bitrate
5f49733 
# Conflicts:
#	src/platform/windows/publish.cpp
#	src_assets/common/assets/web/config.html
@utkarshdalal
Merge branch 'nightly' into add_max_bitrate
3955d2d 
# Conflicts:
#	docs/source/about/advanced_usage.rst
@ReenigneArcher
Merge pull request LizardByte#1334 from LizardByte/nightly
5bca024 
v0.21.0
@utkarshdalal
Merge pull request #3 from utkarshdalal/add_max_bitrate_2
415fe56 
Add max bitrate 2
@utkarshdalal
Merge branch 'nightly' into master
66e8b9f
@utkarshdalal
changes to match remote nightly
82416e8
@utkarshdalal
Merge remote-tracking branch 'upstream/master'
6c667e6
@utkarshdalal
Latest (#8)
fba3265 
* added max bitrate to latest version

* Trigger workflow

* removed third party libraries that were making build fail

* removed another unneeded library

* updated tray ref

* attempt 2 at updating tray

* updated third party moonlight as well fuck this repo

* added logging to see if max bitrate is working

* removed extraneous l
@utkarshdalal
changed ubuntu version to build to 24.04
c19ab77
@utkarshdalal
added dependency so linux appimage builds
99c2152
@ReenigneArcher ReenigneArcher changed the title Added Max Bitrate option feat: Add Max Bitrate option Feb 3, 2025
ReenigneArcher
ReenigneArcher requested changes Feb 3, 2025
View reviewed changes
Copy link
Member

@ReenigneArcher ReenigneArcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think something went wrong with your rebase.

.github/workflows/CI.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert changes in this file

.gitignore Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert changes in this file

docs/Makefile Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert changes in this file

src_assets/common/assets/web/configs/tabs/audiovideo/DisplayModesSettings.vue
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert changes in this file

third-party/Simple-Web-Server Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert changes to this submodule

third-party/ViGEmClient
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert changes to this submodule

third-party/nanors Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert changes to this submodule

third-party/nvapi-open-source-sdk
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert changes to this submodule

third-party/wayland-protocols Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert changes to this submodule

third-party/wlr-protocols Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert changes to this submodule

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 4, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReenigneArcher ReenigneArcher ReenigneArcher requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@utkarshdalal @ReenigneArcher