Skip to content
This repository has been archived by the owner on Oct 13, 2024. It is now read-only.

ci: fix check download assets #367

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented May 23, 2024

Description

More fixes for release event workflow.

Test loop works:

/home/runner/work/Themerr-jellyfin/Themerr-jellyfin/release_downloads/themerr-jellyfin.zip
Archive:  /home/runner/work/Themerr-jellyfin/Themerr-jellyfin/release_downloads/themerr-jellyfin.zip
  inflating: ./release_downloads/0/Jellyfin.Plugin.Themerr.dll  
  inflating: ./release_downloads/0/meta.json  
  inflating: ./release_downloads/0/YoutubeExplode.dll  
  inflating: ./release_downloads/0/themerr-jellyfin.png  
found plugin: /home/runner/work/Themerr-jellyfin/Themerr-jellyfin/release_downloads/themerr-jellyfin.zip

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher ReenigneArcher force-pushed the ci-fix-check-download-assets branch from 692918c to e751dfc Compare May 23, 2024 19:36
Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.97%. Comparing base (0f04edc) to head (e751dfc).
Report is 49 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #367   +/-   ##
=======================================
  Coverage   69.97%   69.97%           
=======================================
  Files           5        5           
  Lines         413      413           
  Branches       36       36           
=======================================
  Hits          289      289           
  Misses        112      112           
  Partials       12       12           

@ReenigneArcher ReenigneArcher marked this pull request as ready for review May 23, 2024 19:41
@ReenigneArcher ReenigneArcher merged commit a8ccfae into master May 23, 2024
17 checks passed
@ReenigneArcher ReenigneArcher deleted the ci-fix-check-download-assets branch May 23, 2024 19:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant