Skip to content
This repository has been archived by the owner on Oct 13, 2024. It is now read-only.

fix(ui): progress bar will now fill to max #217

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

ReenigneArcher
Copy link
Member

Description

There is an issue where the progress bar will not fill to the max, due to an offset of 1.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #217 (5faa20a) into nightly (9057aed) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff            @@
##           nightly     #217   +/-   ##
========================================
  Coverage    67.85%   67.85%           
========================================
  Files           11       11           
  Lines          815      815           
========================================
  Hits           553      553           
  Misses         262      262           
Flag Coverage Δ
Linux 64.78% <ø> (-3.07%) ⬇️
Windows 67.85% <ø> (ø)
macOS 67.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ReenigneArcher ReenigneArcher merged commit aba0560 into nightly Nov 13, 2023
23 checks passed
@ReenigneArcher ReenigneArcher deleted the fix(ui)-progress-bar-will-now-fill-to-max branch November 13, 2023 14:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant