Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(settings): better API test and clean persistence reset #138

Merged
merged 3 commits into from
Jan 26, 2025

Conversation

FrogTheFrog
Copy link
Collaborator

Description

Use better API availability test and also do not try to revert settings anymore in reset - keep it separate.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Copy link

codecov bot commented Jan 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.15%. Comparing base (f434ff2) to head (2ac3386).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #138      +/-   ##
==========================================
+ Coverage   93.11%   93.15%   +0.03%     
==========================================
  Files          34       34              
  Lines        2049     2044       -5     
  Branches     1057     1054       -3     
==========================================
- Hits         1908     1904       -4     
  Misses         81       81              
+ Partials       60       59       -1     
Flag Coverage Δ
Linux 92.98% <ø> (ø)
Windows 92.93% <100.00%> (+0.03%) ⬆️
macOS 74.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nclude/display_device/settings_manager_interface.h 100.00% <ø> (ø)
...play_device/windows/win_display_device_interface.h 100.00% <ø> (ø)
src/windows/settings_manager_general.cpp 100.00% <100.00%> (ø)
src/windows/win_display_device_general.cpp 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@ReenigneArcher ReenigneArcher enabled auto-merge (squash) January 26, 2025 22:03
@ReenigneArcher ReenigneArcher merged commit 53a0ea5 into LizardByte:master Jan 26, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants