Skip to content
This repository has been archived by the owner on Aug 9, 2024. It is now read-only.

refactor: adjust logic for disabling butler tasks #185

Merged
merged 1 commit into from
Dec 25, 2023

Conversation

ReenigneArcher
Copy link
Member

Description

  • Use modulo to calculate butler task hours.
  • Simplify loop for disabling butler tasks.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

Copy link

codecov bot commented Dec 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b8a9ca7) 80.49% compared to head (e20eb00) 80.49%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #185   +/-   ##
=======================================
  Coverage   80.49%   80.49%           
=======================================
  Files          24       24           
  Lines        2907     2907           
=======================================
  Hits         2340     2340           
  Misses        567      567           
Flag Coverage Δ
Python-2.7-Linux 78.77% <ø> (ø)
Python-2.7-Windows 78.77% <ø> (ø)
Python-2.7-macOS 78.77% <ø> (ø)
Python-3.10-Linux 80.35% <ø> (ø)
Python-3.10-Windows 80.35% <ø> (ø)
Python-3.10-macOS 80.35% <ø> (ø)
Python-3.11-Linux 80.35% <ø> (ø)
Python-3.11-Windows 80.35% <ø> (ø)
Python-3.11-macOS 80.35% <ø> (ø)
Python-3.8-Linux 80.24% <ø> (ø)
Python-3.8-Windows 80.24% <ø> (ø)
Python-3.8-macOS 80.24% <ø> (ø)
Python-3.9-Linux 80.30% <ø> (ø)
Python-3.9-Windows 80.30% <ø> (ø)
Python-3.9-macOS 80.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ReenigneArcher ReenigneArcher merged commit 993777d into master Dec 25, 2023
30 checks passed
@ReenigneArcher ReenigneArcher deleted the fix-adjust-logic-for-disabling-butler-tasks branch December 25, 2023 15:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant