Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fail immediately if no commit timestamp found for push event #108

Merged
merged 1 commit into from
Jul 14, 2024

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Jul 14, 2024

Description

After merging #107 this no longer runs properly on push events. This PR probably doesn't actually solve the problem, but adds some debugging prints to the workflow to help investigate the issue further.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

Copy link

codecov bot commented Jul 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.67%. Comparing base (fc138bd) to head (24a9578).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
- Coverage   98.69%   98.67%   -0.02%     
==========================================
  Files           1        1              
  Lines         153      151       -2     
==========================================
- Hits          151      149       -2     
  Misses          2        2              
Files Coverage Δ
action/main.py 98.67% <100.00%> (-0.02%) ⬇️

@ReenigneArcher ReenigneArcher force-pushed the fix-ensure-correct-operation-on-push-events branch 2 times, most recently from cf9e544 to fbba7e3 Compare July 14, 2024 16:48
@ReenigneArcher ReenigneArcher force-pushed the fix-ensure-correct-operation-on-push-events branch from fbba7e3 to 24a9578 Compare July 14, 2024 16:56
@ReenigneArcher ReenigneArcher changed the title fix: ensure correct operation on push events fix: fail immediately if no commit timestamp found for push event Jul 14, 2024
@ReenigneArcher ReenigneArcher marked this pull request as ready for review July 14, 2024 17:17
@ReenigneArcher ReenigneArcher merged commit b5ce309 into master Jul 14, 2024
11 checks passed
@ReenigneArcher ReenigneArcher deleted the fix-ensure-correct-operation-on-push-events branch July 14, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant