Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services.aerospace.settings.on-window-detected has the wrong type #1142

Open
Sabinu opened this issue Nov 4, 2024 · 2 comments
Open

services.aerospace.settings.on-window-detected has the wrong type #1142

Sabinu opened this issue Nov 4, 2024 · 2 comments

Comments

@Sabinu
Copy link

Sabinu commented Nov 4, 2024

on-window-detected = lib.mkOption {

https://nikitabobko.github.io/AeroSpace/guide#on-window-detected-callback

it is not a list of strings; it is a set with atributes: { x = 1; y = 2; }

@Enzime
Copy link
Collaborator

Enzime commented Nov 4, 2024

Could you make a PR?

@teelahti
Copy link

teelahti commented Nov 6, 2024

Similarly, workspace-to-monitor-force-assignment does not work even with the default configuration sample when inside services.aerospace.settings block. Nix complains about the data type:

error: syntax error, unexpected INT_LIT
at /nix/store/2ya55va8svjxbz5hrr5c17iykwgaf2a2-source/nix/hosts/mbp/default.nix:157:7:
   156|     workspace-to-monitor-force-assignment = {
   157|       1 = "1";

If I had to guess, this needs to be raised to be a property of its own, with correct data types.

@Enzime Enzime changed the title AEROSPACE SERVICE: on-window-detected options is not properly typed services.aerospace.settings.on-window-detected has the wrong type Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants