Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add FlashDateSeparators for time separator config #1105

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mmenanno
Copy link

This adds the option to flash the time separators. Found the details around it here https://macos-defaults.com/menubar/flashdateseparators.html#set-to-false-default-value and was able to get it working in my config under:

CustomUserPreferences = {
  "com.apple.menuextra.clock" = {
    FlashDateSeparators = true;
  };
};

With this change you should now be able to do:

menuExtraClock = {
  FlashDateSeparators = true;
};

@mmenanno
Copy link
Author

@Craz1k0ek any idea why two of the tests are failing for me? The error message is unclear to me.

@Craz1k0ek
Copy link

@mmenanno clueless. Might have to do with the default value. You've set it to false, but null might be better

@mmenanno
Copy link
Author

Looks like that fixed it ✅ There is a non-required test that failed, but I believe that is just a flaky test as it is complaining about something unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants