nix: don't allow using auto-optimise-store as it can corrupt the store
#1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilazy
reviewed
Nov 8, 2024
modules/nix/default.nix
Outdated
Comment on lines
532
to
533
| NOTE: This is known to cause Nix Store corruption and using | ||
| {option}`{nix.gc.automatic} instead is recommended. |
There was a problem hiding this comment.
Should probably be a ::: {.warning}, but also if this is getting fixed then we might not need to warn explicitly against it in the description – the assertion should do a good enough job by itself.
There was a problem hiding this comment.
Removed, also ::: {.warning} didn't do anything when I tested it (neither in the manpages or the HTML manual)
Enzime
force-pushed
the
push-rvwwkktwykyt
branch
2 times, most recently
from
9022f32
to
bfc9d8d
Compare
|
Thanks for adding this... it made me realize I had my options backwards on my mac... |
Enzime
force-pushed
the
push-rvwwkktwykyt
branch
from
bfc9d8d
to
068cc8c
Compare
khaneliman
reviewed
Nov 8, 2024
Enzime
force-pushed
the
push-rvwwkktwykyt
branch
from
068cc8c
to
f8541c9
Compare
khaneliman
reviewed
Nov 8, 2024
Enzime
force-pushed
the
push-rvwwkktwykyt
branch
from
f8541c9
to
f0a1269
Compare
emilazy
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream issue at NixOS/nix#7273
Should be fixed by https://gerrit.lix.systems/c/lix/+/2100
Tested the version check with Nix, Lix
2.91.0(pkgs.lixVersions.latest), Lix2.92.0-devpre20241106_1ecfff9(github:lix-project/lix/1ecfff9c37f64871661d615e407ec3571489eff7, doesn't include the fix) and Lix2.92.0-devpre20241107_72cce7b(github:lix-project/lix) which does include the changeCloses #484