dock: allow setting spacer tiles #1187
Conversation
khaneliman
force-pushed
the
spacer
branch
2 times, most recently
from
2915c54 to
9c4bf62
Compare
Using fork until LnL7/nix-darwin#1187 merged
|
Sorry, forgot to update test fixture. |
khaneliman
force-pushed
the
spacer
branch
2 times, most recently
from
9a98401 to
a9b0e9c
Compare
khaneliman
force-pushed
the
spacer
branch
4 times, most recently
from
8ce526e to
e05bd61
Compare
You can create spacer tiles in the dock by passing empty tile-data with specific tile-types
khaneliman
force-pushed
the
spacer
branch
2 times, most recently
from
5010519 to
0c9bacc
Compare
|
Took me too long to realize that I didn't update my flake's usage for spacer tiles.... I was so confused. |
|
@Enzime Alright, sorry I forgot about this for a bit. Updated with last suggested changes. |
| }; | ||
| }; | ||
| in | ||
| types.nullOr (types.listOf (types.coercedTo (types.either types.str types.path)(path: {app = {inherit path;};}) taggedType)); |
There was a problem hiding this comment.
I love the type, but I hate the formatting 🙈
Maybe having the other coercedTo args also be defined in the let-in block would help?
| types.nullOr (types.listOf (types.coercedTo (types.either types.str types.path)(path: {app = {inherit path;};}) taggedType)); | |
| types.nullOr (types.listOf (types.coercedTo simpleType toTagged taggedType)); |
| type = types.submodule { | ||
| options.path = mkOption { | ||
| description = "Path to the folder."; | ||
| type = types.str; | ||
| }; | ||
| }; |
There was a problem hiding this comment.
Don't hold me to this, but assuming an app/folder will only ever need a path value, and it's unlikely this submodule will ever expand, I think we could ditch the submodule and just assign a path directly?
folder = mkOption {
description = "A folder to be added to the dock.";
type = types.str;
# (No default)
};example = [
{ app = "/Applications/Safari.app"; }
{ spacer.small = false; }
{ spacer = { }; }
{ folder = "/System/Applications/Utilities"; }
]There was a problem hiding this comment.
Yeah, I like this more... I was just trying to fulfill the requested form above. #1187 (comment) @Enzime opinion on simplifying it?
There was a problem hiding this comment.
I think a submodule makes sense if we expect there could be other keys to be set in future, e.g. if it was likely you may set path and name or icon or whatever.
I'm not familiar with the tile-data schema so I don't know how likely that is.
| apply = | ||
| let | ||
| toTile = item: if item ? app then { | ||
| tile-data = { file-data = { _CFURLString = item.app.path; _CFURLStringType = 0; }; }; |
There was a problem hiding this comment.
Maybe I've missed some nix-darwin style preference, but IMO this is more readable as:
tile-data.file-data = {
_CFURLString = item.app.path;
_CFURLStringType = 0;
};There was a problem hiding this comment.
I haven't seen any formatter configuration or documentation on formatting in this repo. So, I have no idea whether I should just format the whole file with nixfmt or just try to fit it into whats in here...
There was a problem hiding this comment.
There was a discussion in #1054 that would be worth revisiting. I agree that a default format would be really helpful.
Allows passing in a list of attribute sets for different kinds of tiles.
You can create spacer tiles in the dock by passing empty tile-data with specific tile-types.
Used to do this in my old dotfiles and have been meaning to upstream a change to support doing this in nix-darwin.
