Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(aerospace): allow startup commands #1213

Merged
merged 2 commits into from
Dec 4, 2024
Merged

fix(aerospace): allow startup commands #1213

merged 2 commits into from
Dec 4, 2024

Conversation

z0al
Copy link
Contributor

@z0al z0al commented Dec 4, 2024

The after-startup-command is disabled by mistake. While it's true that the after-login-command doesn't work, the startup commands work just fine (see relevant code)

Enzime
Enzime requested changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@Enzime Enzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the tests?

@z0al z0al requested a review from Enzime December 4, 2024 21:58
@z0al
Copy link
Contributor Author

z0al commented Dec 4, 2024

Can you update the tests?

@Enzime done

Enzime
Enzime approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@Enzime Enzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the contribution

@Enzime Enzime merged commit 55d0781 into LnL7:master Dec 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enzime Enzime Enzime approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@z0al @Enzime