homebrew: allow setting greedy for all casks by default #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilazy
reviewed
Mar 11, 2025
Comment on lines
+505
to
+506
| greedy = mkOption { | ||
| type = types.nullOr types.bool; |
There was a problem hiding this comment.
There’s also --greedy-latest and --greedy-auto-updates, maybe this should be an enum?
There was a problem hiding this comment.
AFAIK the options in this module are is just for Brewfile generation options, rather than being command-line parameters.
The only parameter I know that is possible to pass in regards to greediness of a cask is the boolean greedy: true option, so I would think it's better to not use an enum here and just stick to the boolean. I could be wrong about this tho.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifying the
--greedyflag withbrew upgradefor each cask has to be done on an opt-in basis for each cask specified inhomebrew.casks, which can be rather tedious.This adds an option called
homebrew.greedyCasksthat sets the default value for thehomebrew.casks.*.greedyoption, so that all casks can be changed to be greedy at once, without needing to set that option for each cask. Opting out of--greedyby setting it tofalseper-cask when using this option is possible as well.Closes #572, #1201.