Code for initial release #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This rather sizeable commit is the result of two rounds of prototyping and an initial pull request into a private monorepo before we decided to open source this as an independent repository and npm package. I intend to open a pull request for this to invite a final round of feedback before publishing the initial release and to ensure Github Actions tests the build properly.
|
I see the build failure. That’s my faulty Github Actions setup. Working on it... |
|
...fixed. |
paumoreno
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly the same as lobelia-earth/lobelia-explore#86. I whipped together a quick, mostly trivial test to make sure the exports and source maps worked. They didn’t, partly because I was trying to get fancy by building both minified and un-minified outputs, which is probably not worthwhile since we’re including the source with the package. Anyway, those are fixed now and this is what the test looks like.
Screen.Recording.2024-09-23.at.12.11.08.mov
I can share the source for this test if anyone is curious, but the principle should be the same regardless of whether the state container is Pinia, Redux, or a map engine. So long as you can pass in a well-typed default state object and replace the current state with an object of the same shape, you can use this library.
I closed the other PR before anyone really had a chance to fully review it. Feedback is welcome, especially since I haven’t released this yet. If you have any concerns—especially about the architecture and API design—it will be easier to address those now than after we release.