Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates rubocop config #3462

Merged
merged 1 commit into from
Oct 18, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ Layout/DefEndAlignment:

# Multi-line method chaining should be done with leading dots.
Layout/DotPosition:
EnforcedStyle: leading
EnforcedStyle: trailing
Copy link
Contributor Author

@ivar ivar Sep 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/rubocop-hq/ruby-style-guide#consistent-multi-line-chains
discussion (/flamewar) at rubocop/ruby-style-guide#176
fwiw - I'm a pretty big proponent of trailing dots

SupportedStyles:
- leading
- trailing
Expand Down Expand Up @@ -589,7 +589,7 @@ Layout/SpaceInsideArrayLiteralBrackets:
- no_space

Layout/SpaceInsideBlockBraces:
EnforcedStyle: space
EnforcedStyle: no_space
SupportedStyles:
- space
- no_space
Expand Down