RFC: OMG! They ACTUALLY Made config.sh USEFUL?! (Recursive Patching UNLOCKED!) #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… them Signed-off-by: taalojarvi <sreedevan05@gmail.com>
Comparing the two config scripts, the only difference is that for LTS builds, a patch is omitted. Assuming the patch does not apply, detect if the build targets LTS branch (through ENV we created in a previous PR, and gracefully proceed to build if true. While we are at it, remove config-lts.sh and all mentions of it. Signed-off-by: taalojarvi <sreedevan05@gmail.com>
Added logic to skip applying patches with "_skip_lts" in their filename. This ensures that patches that are not intended for LTS builds can be safely skipped. TODO: Expand the conditional check to cover skipping patches based on build type [LTS / main]. Signed-off-by: taalojarvi <sreedevan05@gmail.com>
…nal.patch` as _skip_lts Signed-off-by: taalojarvi <sreedevan05@gmail.com>
|
Added a commit to address the previous test's failure. EDIT: Apologies on the mess. Slightly sleep deprived today. |
Introduces a check for the IS_LTS environment variable to conditionally apply patches based on build type. Patches containing "_skip_lts" will now be applied during non-LTS builds, even if the filename suggests skipping. Signed-off-by: taalojarvi <sreedevan05@gmail.com>
Error Logs: :: Synchronizing package databases... core downloading... extra downloading... archlinuxcn downloading... error: target not found: llvm-git error: target not found: llvm-libs-git error: target not found: clang-git error: target not found: lld-git * llvm-git, llvm-libs-git, clang-git, lld-git is aur packages, It can't install with pacman. * They support at official packages, So change it. Signed-off-by: Yang Jeong Hun <onyxclover9931@gmail.com> Signed-off-by: taalojarvi <sreedevan05@gmail.com>
…der-file_skip_lts.patch` to patches Signed-off-by: taalojarvi <sreedevan05@gmail.com>
|
Added a few commits to address build failures. |
Locietta
added a commit
that referenced
this pull request
Nov 8, 2024
RFC: OMG! They ACTUALLY Made config.sh USEFUL?! (Recursive Patching UNLOCKED!) #68 Changes to the PR: * use sub-folder in `patches/` to indicate MAIN/LTS spesific patches, instead of add "skip_lts" in patch's name Co-authored-by: taalojarvi <sreedevan05@gmail.com>
Locietta
added a commit
that referenced
this pull request
Nov 8, 2024
RFC: OMG! They ACTUALLY Made config.sh USEFUL?! (Recursive Patching UNLOCKED!) #68 Changes to the PR: * use sub-folder in `patches/` to indicate MAIN/LTS spesific patches, instead of add "skip_lts" in patch's name Co-authored-by: taalojarvi <sreedevan05@gmail.com>
Locietta
added a commit
that referenced
this pull request
Nov 8, 2024
RFC: OMG! They ACTUALLY Made config.sh USEFUL?! (Recursive Patching UNLOCKED!) #68 Changes to the PR: * use sub-folder in `patches/` to indicate MAIN/LTS spesific patches, instead of add "skip_lts" in patch's name * Add `-lts` CLI option for manual override (for testing locally) Co-authored-by: taalojarvi <sreedevan05@gmail.com>
Locietta
added a commit
that referenced
this pull request
Nov 8, 2024
RFC: OMG! They ACTUALLY Made config.sh USEFUL?! (Recursive Patching UNLOCKED!) #68 Changes to the PR: * use sub-folder in `patches/` to indicate MAIN/LTS spesific patches, instead of add "skip_lts" in patch's name * Add `-lts` CLI option for manual override (for testing locally) Co-authored-by: taalojarvi <sreedevan05@gmail.com>
|
Merged as 37eb8d1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces two improvements to the patching script (config.sh):
Unified Script & LTS Build Handling:
Improved Patch Management:
Benefits
Detailed build log available here.