Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite unzipping logic with libraries instead of 7z #101

Closed
CheatCod opened this issue Feb 2, 2023 · 0 comments · Fixed by #118
Closed

Rewrite unzipping logic with libraries instead of 7z #101

CheatCod opened this issue Feb 2, 2023 · 0 comments · Fixed by #118
Assignees
@jasonw930
Labels
enhancement New feature or request
Milestone
0.4.3

Comments

@CheatCod
Copy link
Member

CheatCod commented Feb 2, 2023

Description

Currently the core downloads and invoke 7z to handle zipping and unzipping. This is not ideal for multiple reasons.

Rewrite the unzipping logic to use libraries.

https://rust-lang-nursery.github.io/rust-cookbook/compression/tar.html

https://github.com/google/ripunzip

https://github.com/muja/unrar.rs
@CheatCod CheatCod added the enhancement New feature or request label Feb 11, 2023
@CheatCod CheatCod added this to the 0.4.2 milestone Feb 11, 2023
@CheatCod CheatCod modified the milestones: 0.4.2, 0.4.3 Feb 28, 2023
@CheatCod CheatCod linked a pull request Feb 28, 2023 that will close this issue
ZIP #118
Merged
4 tasks
Ynng added a commit that referenced this issue Jul 17, 2023
@Ynng
closes #101, editted toml regex to not use lookbehind
c6a8da7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasonw930 jasonw930

Labels
enhancement New feature or request
Projects
Lodestone Core
Status: ✅ Done
Milestone
0.4.3
Development

Successfully merging a pull request may close this issue.

ZIP Lodestone-Team/lodestone_core
2 participants
@jasonw930 @CheatCod