Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null value deprecation error for Str::endsWith #27

Merged
merged 1 commit into from
Jul 28, 2024
Merged

Fix null value deprecation error for Str::endsWith #27

merged 1 commit into from
Jul 28, 2024

Conversation

LeoColomb
Copy link
Contributor

This is almost nothing but is hitting me hard right now.
When the bundle values are missing (which can happen for different reasons), then the local value gets null which is not accepted as an argument for Str::endsWith().

ErrorException: Deprecated: str_ends_with(): Passing null to parameter #1 ($haystack) of type string is deprecated
#44 root/vendor/illuminate/support/Str.php(322): Illuminate\Support\Str::endsWith
#43 root/vendor/log1x/sage-svg/src/SageSvg.php(96): Log1x\SageSvg\SageSvg::asset
#42 root/vendor/log1x/sage-svg/src/SageSvg.php(69): Log1x\SageSvg\SageSvg::getContents
#41 root/vendor/log1x/sage-svg/src/SageSvg.php(49): Log1x\SageSvg\SageSvg::render
#40 root/vendor/log1x/sage-svg/src/helpers.php(16): get_svg
#39 root/web/app/themes/theme/storage/framework/views/246666fbe147d06bbcf009f62287874f.php(8): require

@Log1x Log1x merged commit 257b533 into Log1x:master Jul 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants