Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-introduce hybrid repo, add some tests for it #155

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Conversation

NeilMountford
Copy link
Contributor

This PR:

  • Re-introduces the hybrid repo, fixing an error where requesting it from DI would always fail as it wasn't registered (but the type was public)
  • Re-introduces the GetSnapshotWithCatchupExpensively method. I think this is useful for reading a single entity where the stream could end up having a lot of events in it
  • Adds some tests to give the hybrid repo some basic coverage, as it currently had none
  • Adds a summary section to the hybrid repo advising on when and where it is suitable

@NeilMountford NeilMountford merged commit 1e1a445 into main Aug 8, 2023
2 checks passed
@NeilMountford NeilMountford deleted the hybrid-repo branch August 8, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants