Ctsstc/issue41 #42
Merged
Ctsstc/issue41 #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #41 Updates redundant styles to a new container in index. I like the component not owning the styling as well. The container in index also handles flex styling on the children elements that are contained. Remove sass from prettier because it doesn't support sass 🤯 Relevant Discord Chat: found out while digging a few things that even though sass and scss are super close there's a lot less tooling and underlying architecture issues that lacks sass support :' ( I guess prettier doesn't support it; and likely because of these other underlying issues, I guess google is running the dart sass team but doesn't have time to do what we all need : ( prettier/prettier#4948 mrmlnc/vscode-scss#127 sass/dart-sass#88 Interesting long technical read though TLDR; needs to have support for ASTs which allow code tools to help code; dart has no easy way to expose it It's finally on a roadmap but then they said they won't ever get to it lol classic product things
Deploying with
|
| Latest commit: |
19f762a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f1606071.musical-conquest.pages.dev |
|
✔️ Deploy Preview for musical-conquest ready! 🔨 Explore the source changes: 19f762a 🔍 Inspect the deploy log: https://app.netlify.com/sites/musical-conquest/deploys/61876e2493c9010008a30896 😎 Browse the preview: https://deploy-preview-42--musical-conquest.netlify.app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41
Updates redundant styles to a new container in index. I like the component not owning the styling as well. The container in index also handles flex styling on the children elements that are contained.
Remove sass from prettier because it doesn't support sass 🤯
Relevant Discord Chat:
found out while digging a few things that even though sass and scss are super close there's a lot less tooling and underlying architecture issues that lacks sass support :' (
I guess prettier doesn't support it; and likely because of these other underlying issues, I guess google is running the dart sass team but doesn't have time to do what we all need : (
prettier/prettier#4948
mrmlnc/vscode-scss#127
sass/dart-sass#88
Interesting long technical read though
TLDR; needs to have support for ASTs which allow code tools to help code; dart has no easy way to expose it
It's finally on a roadmap but then they said they won't ever get to it lol
classic product things