Make must_cast by-value and by-shared-ref functions const #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(I believe the CI failures are due to rust-lang/rust#128808) |
|
Because it's an optional feature and because 1.64 is quite old at this point i think we can ignore the msrv. I'd like to probably wait on CI if the nightly rust bug is going to only be a day or two |
…nt for must_cast MSRV.
zachs18
force-pushed
the
must_cast_const
branch
from
8ba1d6f to
e40626a
Compare
|
(Current nightly has the fix; force-pushed for CI) |
|
Released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(but not by-mut-ref, since that's not stable).
This would raise the MSRV of the
must_castfeature from 1.57.0 to 1.64.0 (whenslice_from_raw_partswas made const-stable). Alternately, this could be added as a new feature (const_must_cast?) with its own MSRV1.The new arm of the
transmute!macro is to work around borrowing a generic type in const-eval not being allowed on stable, since the borrowed type could have interior mutabilty. Transmuting viauniondoes not have this issue, since no borrowing occurs.Footnotes
must_castandmust_cast_ref's MSRV is at least 1.61.0, whenconst_fn_trait_boundwas stabilized.must_cast_slice's MSRV is at least 1.64.0, as mentioned. ↩