Fix ArrayVec capacity not taking u16::MAX into account #178
Conversation
|
u16::MAX wasn't available until rust 1.43 This is probably a good time to "implement" #174 and up the CI. I can't even remember what exactly was allowed in what versions that long ago (other than 1.36 being "the one with alloc"). Stable is currently 1.67, so let's go with "Stable-20" and bump the tinyvec CI to use rust 1.47. Sorry to throw this extra work at you. If you'd like to also fix up the cargo features based on what 1.47 allows that would be nice but you don't have to. |
|
What should happen to the |
|
I'd like to keep this PR focused on this change. I'll change the CI to run 1.47 but won't track down other stuff for now. |
|
Sounds good, we can handle that PR first and then come back to this one. |
|
I think i can get it to run CI again if i just close and reopen the PR... |
The capacity is limited by the backing array and u16::MAX because the length is stored as a u16. This was not taken into account in the `fn capacity` implementation.
|
I rebased it to main. |
The capacity is limited by the backing array and u16::MAX because the length is stored as a u16. This was not taken into account in the
fn capacityimplementation.