Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded files from crate package #185

Merged
merged 2 commits into from
Sep 4, 2023
Merged

Remove unneeded files from crate package #185

merged 2 commits into from
Sep 4, 2023

Conversation

Jake-Shadle
Copy link
Contributor

No description provided.

@Shnatsel
Copy link
Collaborator

What's the difference in package size before and after? Is it significant enough to bother?

For example dropping the 5kb README on debugger visualizers seems questionable.

@Jake-Shadle
Copy link
Contributor Author

This isn't about size necessarily, but just not packaging any files that aren't actually needed for downstream users, notably the executable scripts. I'll add back the visualizer README.

@Lokathor Lokathor merged commit d1a4700 into Lokathor:main Sep 4, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shnatsel Shnatsel Shnatsel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jake-Shadle @Shnatsel @Lokathor