Fix rustc features not depending on each other #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This crate has several features related to the rustc version. It is currently a bug that not all off these features depend on the lower rustc version features. This commit fixes this. This bug leads to bad user experience. For example, you notice that by default tinyvec doesn't work with arrays of all sizes. The docs tell you to enable the rustc_1_55 feature to fix this. You see that there are features for even newer rustc versions so you pick the most recent one because you use the current stable compiler. To your surprise, this does not enable tinyvec to work with arrays of all sizes. This change is correct because features are additive and rustc versions are backward compatible.
e00E
changed the title
|
I thought we already had it this way, good fix. |
|
released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This crate has several features related to the rustc version. It is currently a bug that not all off these features depend on the lower rustc version features. This commit fixes this.
This bug leads to bad user experience. For example, you notice that by default tinyvec doesn't work with arrays of all sizes. The docs tell you to enable the rustc_1_55 feature to fix this. You see that there are features for even newer rustc versions so you pick the most recent one because you use the current stable compiler. To your surprise, this does not enable tinyvec to work with arrays of all sizes.
This change is correct because features are additive and rustc versions are backward compatible.