-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"try_*" functions and "to_vec" for arrayvec #82
Conversation
I'm thinking if |
Well for one thing it looks like you added no tests at all >_> |
From Vec::reserve_exact
So technically tests for |
Appveyor test died, because of |
ah, yeah, gotta be really strict on keeping to a minimum version im afraid. |
You can merge this PR (with #80) if you don't have any objections. |
okay, 80 first, then this, then we can update the 3rd PR to use reserve. |
oh i forgot that i haven't reviewed this yet. I'll have to sit down and look closely later today. In the mean time, it looks like merging #80 made some conflicts here. |
one conflict was because I left previously just one new line in |
I am literally now sitting in github file editor, hoping that it will work 🙃 |
Now I understand the merge conflict joke |
|
there's already a |
CI seems happy now. Travis is just flaky sometimes. |
Plus, a bit of rewrite of tinyvec to use them.