Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Rand crate #180

Merged
merged 5 commits into from
Aug 20, 2024
Merged

Remove Rand crate #180

merged 5 commits into from
Aug 20, 2024

Conversation

mcroomp
Copy link
Contributor

@mcroomp mcroomp commented Aug 20, 2024

Causing dependency problems. Replace with simple LCG since it is just used for generating test value.

Also moved non_upper_case_globals into macro so that the visual studio code analyzer doesn't complain and generate bogus warnings.

@mcroomp mcroomp mentioned this pull request Aug 20, 2024
Copy link
Owner

@Lokathor Lokathor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think with this we could set our MSRV back lower, but that's for another day, if anyone really cares (I don't think anyone cares about MSRV that far back).

@Lokathor Lokathor merged commit c10ce3a into Lokathor:main Aug 20, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants