implement floor and ceil for f64 and f32 types #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kralverde
force-pushed
the
floor_ceil
branch
from
dc28800 to
079acac
Compare
|
It looks like the workflow is broken for WASM other than stable, but running all other workflows succeeded for me locally. |
Lokathor
approved these changes
Dec 2, 2024
|
The WASI target is now called |
Thanks this worked, but now it looks like there's some kind of permission issue with the workflows... |
|
Now an architecture error... I'm not super familiar with wasm if anyone wants to pitch in |
|
I'm gonna merge this, the wasm stuff shouldn't be on your shoulders. @CryZe can you fix the wasm ci setup at some point later? |
|
The problem is that it's still the old target name here (and possibly other places): https://github.com/Lokathor/wide/blob/main/.cargo-ci/config#L11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
floorandceilfunctions for the f64 and f32 types.